[cleanup/tensor, part 2] Modularized tests for contiguity, retrieval of PyUSMArrayObject* and removed use of a global variable.#931
Merged
oleksandr-pavlyk merged 4 commits intocleanup/tensorfrom Oct 13, 2022
Conversation
|
View rendered docs @ https://intelpython.github.io/dpctl/pulls/931/index.html |
|
Array API standard conformance tests for dpctl=0.14.0dev0=py310h8c27c75_175 ran successfully. |
Use -O1 when compiling tensor_py for now to work around suspected issue with loading of C-API functions.
…es`. The class is already singleton. Instead create a local variable at each use site. This local variable is going to be a constant reference to the singleton.
2c3c962 to
7d2ab88
Compare
|
Array API standard conformance tests for dpctl=0.14.0dev0=py310h8c27c75_175 ran successfully. |
Contributor
Author
|
@diptorupd ping |
diptorupd
approved these changes
Oct 13, 2022
Contributor
diptorupd
left a comment
There was a problem hiding this comment.
Overall looks fine to me. I am unable to go into too much detail with the review. As CI is gree, please merge!
|
Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduced
dpctl::tensor::usm_ndarray::is_c_contiguousanddpctl::tensor::usm_ndarray::is_f_contiguousand used them intensor_py.cpp.Modularized common operation of retrieving
PyUSMArrayObject *into a private method and used it in methods ofdpctl::tensor::usm_ndarray.Got rid of global variable
static dpctl::tensor::detail::usm_ndarray_types array_typesintensor_py.cpp. Since the type implements singleton, call itsget()method at each use site.