Skip to content

Exported data types, finfo and iinfo symbols#913

Merged
oleksandr-pavlyk merged 6 commits intomasterfrom
add-dtypes-and-infos
Oct 10, 2022
Merged

Exported data types, finfo and iinfo symbols#913
oleksandr-pavlyk merged 6 commits intomasterfrom
add-dtypes-and-infos

Conversation

@oleksandr-pavlyk
Copy link
Copy Markdown
Contributor

@oleksandr-pavlyk oleksandr-pavlyk commented Sep 19, 2022

This PR adds data type objects to dpct.tensor namespace, specifically

dpctl.tensor.bool
dpctl.tensor.int8
dpctl.tensor.uint8
dpctl.tensor.int16
dpctl.tensor.uint16
dpctl.tensor.int32
dpctl.tensor.uint32
dpctl.tensor.int64
dpctl.tensor.uint64
dpctl.tensor.float16
dpctl.tensor.float32
dpctl.tensor.float64
dpctl.tensor.complex64
dpctl.tensor.complex128

This also adds dpctl.tensor.iinfo and dpctl.tensor.finfo. These are directly imported from numpy.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • If this PR is a work in progress, are you filing the PR as a draft?

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Sep 19, 2022

View rendered docs @ https://intelpython.github.io/dpctl/pulls/913/index.html

@coveralls
Copy link
Copy Markdown
Collaborator

coveralls commented Sep 19, 2022 •
edited
Loading

Coverage Status

Coverage increased (+0.02%) to 82.136% when pulling 21a6aaa on add-dtypes-and-infos into 8cbed99 on master.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Sep 19, 2022

Array API standard conformance tests for dpctl=0.14.0dev0=py310h8c27c75_118 ran successfully.
Passed: 28
Failed: 806
Skipped: 3157

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Sep 21, 2022

Array API standard conformance tests for dpctl=0.14.0dev0=py310h8c27c75_121 ran successfully.
Passed: 22
Failed: 812
Skipped: 3157

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Sep 21, 2022

Array API standard conformance tests for dpctl=0.14.0dev0=py310h8c27c75_123 ran successfully.
Passed: 22
Failed: 812
Skipped: 3157

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Sep 22, 2022

Array API standard conformance tests for dpctl=0.14.0dev0=py310h8c27c75_124 ran successfully.
Passed: 31
Failed: 803
Skipped: 3157

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Oct 5, 2022

Array API standard conformance tests for dpctl=0.14.0dev0=py310h8c27c75_145 ran successfully.
Passed: 32
Failed: 802
Skipped: 3157

@oleksandr-pavlyk oleksandr-pavlyk marked this pull request as ready for review October 5, 2022 22:46
@diptorupd diptorupd marked this pull request as draft October 7, 2022 20:59
oleksandr-pavlyk
oleksandr-pavlyk commented Oct 7, 2022
View reviewed changes
Comment thread dpctl/tensor/_manipulation_functions.py Outdated
@diptorupd diptorupd marked this pull request as ready for review October 7, 2022 21:21
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Oct 7, 2022

Array API standard conformance tests for dpctl=0.14.0dev0=py310h8c27c75_150 ran successfully.
Passed: 32
Failed: 802
Skipped: 3157

oleksandr-pavlyk
oleksandr-pavlyk commented Oct 7, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor Author

@oleksandr-pavlyk oleksandr-pavlyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR looks good to me. @npolina4 if you approve this, we can merge it.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Oct 10, 2022

Array API standard conformance tests for dpctl=0.14.0dev0=py310h8c27c75_163 ran successfully.
Passed: 33
Failed: 801
Skipped: 3138

@oleksandr-pavlyk oleksandr-pavlyk merged commit 051e473 into master Oct 10, 2022
@oleksandr-pavlyk oleksandr-pavlyk deleted the add-dtypes-and-infos branch October 10, 2022 21:19
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Oct 10, 2022

Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Oct 10, 2022

Array API standard conformance tests for dpctl=0.14.0dev0=py310h8c27c75_163 ran successfully.
Passed: 33
Failed: 801
Skipped: 3138

@oleksandr-pavlyk oleksandr-pavlyk mentioned this pull request Nov 4, 2022
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@npolina4 npolina4 Awaiting requested review from npolina4

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@oleksandr-pavlyk @coveralls @npolina4