Skip to content

Fixed filter-selector-string output by lsplatform and print_device_info#866

Merged
oleksandr-pavlyk merged 1 commit intomasterfrom
fix-filter-string-construction-in-lsplatform
Jul 28, 2022
Merged

Fixed filter-selector-string output by lsplatform and print_device_info#866
oleksandr-pavlyk merged 1 commit intomasterfrom
fix-filter-string-construction-in-lsplatform

Conversation

@oleksandr-pavlyk
Copy link
Copy Markdown
Contributor

@oleksandr-pavlyk oleksandr-pavlyk commented Jul 26, 2022

SYCLInterface library functions used std::to_string(sycl::backend d.get_platform().get_backend()) to produce backend section of the filter selector. Correspondingly they produced invalid strings like "ext_oneapi_level_zero:gpu:0" where "level_zero:gpu:0" was expected.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?

For example, now:

Platform  3 ::
    Name        Intel(R) Level-Zero
    Version     1.3
    Vendor      Intel(R) Corporation
    Backend     ext_oneapi_level_zero
    Num Devices 1
      # 0
        Name                Intel(R) UHD Graphics [0x9bca]
        Version             1.3.23750
        Filter string       level_zero:gpu:0

While previously the filter string was "ext_oneapi_level_zero:gpu:0".

Similar change for print_device_info:

$ SYCL_FILTER_SELECTOR=level python -c "import dpctl; dpctl.SyclDevice().print_device_info()"
    Name            Intel(R) UHD Graphics [0x9bca]
    Driver version  1.3.23750
    Vendor          Intel(R) Corporation
    Profile         FULL_PROFILE
    Filter string   level_zero:gpu:0

Previously the filter string used to be "ext_oneapi_level_zero:gpu:0".

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jul 26, 2022

View rendered docs @ https://intelpython.github.io/dpctl/pulls/866/index.html

@coveralls
Copy link
Copy Markdown
Collaborator

coveralls commented Jul 26, 2022 •
edited
Loading

Coverage Status

Coverage decreased (-0.06%) to 81.529% when pulling 7b5b4c1 on fix-filter-string-construction-in-lsplatform into 299bd7e on master.

diptorupd
diptorupd reviewed Jul 26, 2022
View reviewed changes
Comment thread libsyclinterface/source/dpctl_sycl_device_manager.cpp
@oleksandr-pavlyk
Copy link
Copy Markdown
Contributor Author

oleksandr-pavlyk commented Jul 26, 2022

Even though SYCL_DEVICE_FILTER does recognize ext_oneapi_level_zero as backend, the DPCTL does not:

In [1]: import dpctl

In [2]: dpctl.SyclDevice("level_zero:gpu:0")
Out[2]: <dpctl.SyclDevice [backend_type.level_zero, device_type.gpu,  Intel(R) UHD Graphics [0x9bca]] at 0x7f3f6ed76cf0>

In [3]: dpctl.SyclDevice("ext_oneapi_level_zero:gpu:0")
---------------------------------------------------------------------------
SyclDeviceCreationError                   Traceback (most recent call last)
Input In [3], in <cell line: 1>()
----> 1 dpctl.SyclDevice("ext_oneapi_level_zero:gpu:0")

File ~/repos/dpctl/dpctl/_sycl_device.pyx:293, in dpctl._sycl_device.SyclDevice.__cinit__()
    291 ret = self._init_from_selector(DSRef)
    292 if ret == -1:
--> 293     raise SyclDeviceCreationError(
    294         "Could not create a SyclDevice with the selector string"
    295     )

SyclDeviceCreationError: Could not create a SyclDevice with the selector string

@oleksandr-pavlyk
Fixed filter-selector-string output by lspltform and print_device_info
7b5b4c1 
For example, now:

```
Platform  3 ::
    Name        Intel(R) Level-Zero
    Version     1.3
    Vendor      Intel(R) Corporation
    Backend     ext_oneapi_level_zero
    Num Devices 1
      # 0
        Name                Intel(R) UHD Graphics [0x9bca]
        Version             1.3.23750
        Filter string       level_zero:gpu:0
```

While previously the filter string was "ext_oneapi_level_zero:gpu:0".

Similar change for print_device_info:

```
$ SYCL_FILTER_SELECTOR=level python -c "import dpctl; dpctl.SyclDevice().print_device_info()"
    Name            Intel(R) UHD Graphics [0x9bca]
    Driver version  1.3.23750
    Vendor          Intel(R) Corporation
    Profile         FULL_PROFILE
    Filter string   level_zero:gpu:0
```

Previously the filter string used to be "ext_oneapi_level_zero:gpu:0".
@oleksandr-pavlyk oleksandr-pavlyk force-pushed the fix-filter-string-construction-in-lsplatform branch from cb80117 to 7b5b4c1 Compare July 27, 2022 03:14
@oleksandr-pavlyk oleksandr-pavlyk changed the title Fixed filter-selector-string output by lspltform and print_device_info Fixed filter-selector-string output by lsplatform and print_device_info Jul 27, 2022
@oleksandr-pavlyk
Copy link
Copy Markdown
Contributor Author

oleksandr-pavlyk commented Jul 28, 2022

Ok, I've addressed @diptorupd feedback. Merging now.

@oleksandr-pavlyk oleksandr-pavlyk merged commit c09ac88 into master Jul 28, 2022
@oleksandr-pavlyk oleksandr-pavlyk deleted the fix-filter-string-construction-in-lsplatform branch July 28, 2022 15:08
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jul 28, 2022

Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@diptorupd diptorupd Awaiting requested review from diptorupd

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@oleksandr-pavlyk @coveralls @diptorupd