Skip to content

Modularized the examples/pybind11/onemkl_gemv/sycl_timing_solver.py#838

Merged
oleksandr-pavlyk merged 1 commit intomasterfrom
clean-up-sycl-timing-solver
May 17, 2022
Merged

Modularized the examples/pybind11/onemkl_gemv/sycl_timing_solver.py#838
oleksandr-pavlyk merged 1 commit intomasterfrom
clean-up-sycl-timing-solver

Conversation

@oleksandr-pavlyk
Copy link
Copy Markdown
Contributor

This PR changes the runner script to modularize sections iterating different solvers.

This mostly meant defining functions with proper docstrings and calling them. Now commenting out section testing cpp or python implementation is a one-line change.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?

@github-actions
Copy link
Copy Markdown

@oleksandr-pavlyk oleksandr-pavlyk force-pushed the clean-up-sycl-timing-solver branch from 0d5c850 to c1c1668 Compare May 17, 2022 18:52
@coveralls
Copy link
Copy Markdown
Collaborator

Coverage Status

Coverage remained the same at 82.825% when pulling c1c1668 on clean-up-sycl-timing-solver into f94ef5e on master.

@oleksandr-pavlyk oleksandr-pavlyk merged commit 50be964 into master May 17, 2022
@oleksandr-pavlyk oleksandr-pavlyk deleted the clean-up-sycl-timing-solver branch May 17, 2022 19:22
@github-actions
Copy link
Copy Markdown

Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants