Skip to content

Remove unnecessary arg member of SyclEvent/_SyclEvent classes #823

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
oleksandr-pavlyk merged 1 commit into from
Apr 28, 2022
Merged

Remove unnecessary arg member of SyclEvent/_SyclEvent classes #823

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions dpctl/_sycl_event.pxd
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,6 @@ cdef public api class _SyclEvent [
""" Data owner for SyclEvent
"""
cdef DPCTLSyclEventRef _event_ref
cdef object args


cdef public api class SyclEvent(_SyclEvent) [
Expand All @@ -40,7 +39,7 @@ cdef public api class SyclEvent(_SyclEvent) [
""" Python wrapper class for a ``cl::sycl::event``
"""
@staticmethod
cdef SyclEvent _create (DPCTLSyclEventRef event, object args=*)
cdef SyclEvent _create (DPCTLSyclEventRef event)
cdef int _init_event_default(self)
cdef int _init_event_from__SyclEvent(self, _SyclEvent other)
cdef int _init_event_from_capsule(self, object caps)
Expand Down
9 changes: 2 additions & 7 deletions dpctl/_sycl_event.pyx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,6 @@ cdef class _SyclEvent:
if (self._event_ref):
DPCTLEvent_Delete(self._event_ref)
self._event_ref = NULL
self.args = None


cdef class SyclEvent(_SyclEvent):
Expand Down Expand Up @@ -140,7 +139,7 @@ cdef class SyclEvent(_SyclEvent):
"""

@staticmethod
cdef SyclEvent _create(DPCTLSyclEventRef eref, object args=None):
cdef SyclEvent _create(DPCTLSyclEventRef eref):
""""
This function calls DPCTLEvent_Delete(eref).

Expand All @@ -149,21 +148,18 @@ cdef class SyclEvent(_SyclEvent):
"""
cdef _SyclEvent ret = _SyclEvent.__new__(_SyclEvent)
_init_helper(ret, eref)
ret.args=args
return SyclEvent(ret)

cdef int _init_event_default(self):
self._event_ref = DPCTLEvent_Create()
if (self._event_ref is NULL):
return -1
self.args=None
return 0

cdef int _init_event_from__SyclEvent(self, _SyclEvent other):
self._event_ref = DPCTLEvent_Copy(other._event_ref)
if (self._event_ref is NULL):
return -1
self.args = other.args
return 0

cdef int _init_event_from_capsule(self, object cap):
Expand All @@ -183,7 +179,6 @@ cdef class SyclEvent(_SyclEvent):
if (ERef_copy is NULL):
return -3
self._event_ref = ERef_copy
self.args = None
return 0
else:
return -128
Expand Down Expand Up @@ -331,7 +326,7 @@ cdef class SyclEvent(_SyclEvent):
events = []
for i in range(num_events):
ERef = DPCTLEventVector_GetAt(EVRef, i)
events.append(SyclEvent._create(ERef, args=None))
events.append(SyclEvent._create(ERef))
DPCTLEventVector_Delete(EVRef)
return events

Expand Down
4 changes: 2 additions & 2 deletions dpctl/_sycl_queue.pyx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -845,7 +845,7 @@ cdef class SyclQueue(_SyclQueue):
# free memory
free(arg_objects)

return SyclEvent._create(Eref, [])
return SyclEvent._create(Eref)

cpdef void wait(self):
with nogil: DPCTLQueue_Wait(self._queue_ref)
Expand Down Expand Up @@ -996,7 +996,7 @@ cdef class SyclQueue(_SyclQueue):
"Barrier submission to Sycl queue failed."
)

return SyclEvent._create(ERef, [])
return SyclEvent._create(ERef)

@property
def name(self):
Expand Down