CYTHON_TRACE must be set when generating coverage#752
Merged
oleksandr-pavlyk merged 4 commits intomasterfrom Feb 1, 2022
Merged
CYTHON_TRACE must be set when generating coverage#752oleksandr-pavlyk merged 4 commits intomasterfrom
oleksandr-pavlyk merged 4 commits intomasterfrom
Conversation
|
View rendered docs @ https://intelpython.github.io/dpctl/pulls/752/index.html |
Collaborator
5630a80 to
631d40a
Compare
76377de to
1f7ed9c
Compare
Setting of this proprocessor variable went missing in the move to cmake + scikit-build, resulting in coverage not going through Cython files anymore. This change should restore that, and thus improve the coverage percentage.
When cython converts .pyx files to cxx it is now provided a working directory option. This makes sure that generated `__pyx_f` array lists sources relative to project directory. When generating coverage, cmake adds a target to copy generated .cxx files to the location of .pyx file.
1f7ed9c to
6fab702
Compare
|
Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Setting of this preprocessor variable went missing in the move to
cmake + scikit-build (#746), resulting in coverage not going through Cython
files anymore. This change should restore that, and thus improve the
coverage percentage.