Fixes #693 : Reshape clears contiguity flags#695
Merged
oleksandr-pavlyk merged 1 commit intomasterfrom Nov 30, 2021
Merged
Conversation
Constructor make more rigorous checks for contiguity flags. When constructor is checking contiguity of the 1D array, it needs to account for 1-element array no matter the value of strides[0]. Similarly for higher dimensionality, contiguity check should not take into account slots with dimensions of 1. X1 = usm_ndarray((1,3,1), 'i4', 'device', strides=(0,1,0)) X2 = usm_ndarray((2,1,3), 'i4', 'device', strides=(3, 0, 1)) X3 = usm_ndarray((2,1,3), 'i4', 'device', strides=(1, 0, 2))
|
View rendered docs @ https://intelpython.github.io/dpctl/pulls/695/index.html |
Collaborator
densmirn
approved these changes
Nov 30, 2021
|
Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Constructor make more rigorous checks for contiguity flags.
This fixes #693
When constructor is checking contiguity of the 1D array, it needs to
account for 1-element array no matter the value of strides[0].
Similarly for higher dimensionality, contiguity check should not
take into account slots with dimensions of 1.
tests added.