Skip to content

array_info_sequence handles empty sequences as host data#694

Merged
oleksandr-pavlyk merged 2 commits intomasterfrom
gh687-asarray-empty-list
Nov 30, 2021
Merged

array_info_sequence handles empty sequences as host data#694
oleksandr-pavlyk merged 2 commits intomasterfrom
gh687-asarray-empty-list

Conversation

@oleksandr-pavlyk
Copy link
Copy Markdown
Contributor

@oleksandr-pavlyk oleksandr-pavlyk commented Nov 29, 2021

Closes #687, #690

_array_info_sequence should handle empty sequences as host data. Added a test for this input.

@github-actions
Copy link
Copy Markdown

@coveralls
Copy link
Copy Markdown
Collaborator

coveralls commented Nov 29, 2021

Coverage Status

Coverage increased (+0.03%) to 74.819% when pulling 5f279d6 on gh687-asarray-empty-list into ad06973 on master.

Since bool is a subclass of int, the lack of missing test for
instance of bool was being handled by test for instance of int.

Fixed implementation, added a test.
@oleksandr-pavlyk oleksandr-pavlyk merged commit d9cfb43 into master Nov 30, 2021
@oleksandr-pavlyk oleksandr-pavlyk deleted the gh687-asarray-empty-list branch November 30, 2021 12:51
@github-actions
Copy link
Copy Markdown

Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

dpctl.tensor.asarray raises TypeError with empty list as input

3 participants