Closed
Conversation
Closed
Contributor
Author
|
@oleksandr-pavlyk @adarshyoga I am counting on your reviews and help in filling in the missing pieces. :) |
Collaborator
| `dpnp <https://intelpython.github.io/dpnp/>`_ package, a NumPy-like | ||
| library of pre-compiled kernels written in the | ||
| `SYCL language <https://sycl.readthedocs.io/en/latest/index.html>`_. Dpnp too | ||
| uses dpctl to schedule and execute the kernels it provides. |
Contributor
There was a problem hiding this comment.
Dpnp too uses dpctl to schedule and execute the kernels it provides.
I do not think this is true. dpnp only uses dpctl.SyclQueue provided by the user, and submits to that queue by directly calling the DPC++ run-time, i.e. q.submit(...).
Contributor
There was a problem hiding this comment.
dpctl.tensor will also be using DPC++ runtime directly.
695cd06 to
1cead76
Compare
Contributor
|
@diptorupd , let me take a stab at queues and submitting kernels. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The PR seeks to address the long overdue overhaul of dpctl's documentation. I have started rewriting the introductory paragraphs and added stubs for a user manual that remains to be filled.