Skip to content

Rename dpctl capi#666

Merged
diptorupd merged 5 commits intoIntelPython:masterfrom
diptorupd:rename-dpctl-capi
Nov 10, 2021
Merged

Rename dpctl capi#666
diptorupd merged 5 commits intoIntelPython:masterfrom
diptorupd:rename-dpctl-capi

Conversation

@diptorupd
Copy link
Copy Markdown
Contributor

@diptorupd diptorupd commented Nov 9, 2021

The name dpctl-capi is misleading and a legacy of a previous design vision for dpctl. The PR renames dpctl-capi to libsyclinterface to better reflect the intent of the helper library, i.e., to provide a C API wrapper for DPC++'s SYCL run time.

@diptorupd diptorupd marked this pull request as draft November 9, 2021 22:25
@coveralls
Copy link
Copy Markdown
Collaborator

coveralls commented Nov 9, 2021 •
edited
Loading

Coverage Status

Coverage remained the same at 74.445% when pulling d453e7d on diptorupd:rename-dpctl-capi into f292953 on IntelPython:master.

@diptorupd diptorupd marked this pull request as ready for review November 10, 2021 00:18
@oleksandr-pavlyk
Copy link
Copy Markdown
Contributor

oleksandr-pavlyk commented Nov 10, 2021 •
edited
Loading

Should we then also restructure dpctl_installation_dir/include to the following layout?

  include/
    sycl_interface/
        Config/
        Support/
        *.h   /* all *.h files from present include/*.h */
    dpctl/
         dpctl_api.h    /* shallow files containing #include "../../_sycl_queue_api.h" and others */
    pybind11/
         dpctl.h        /* definitions for the C++ classes and casters to/from dpctl Python types */

@diptorupd
Copy link
Copy Markdown
Contributor Author

diptorupd commented Nov 10, 2021

Should we then also restructure dpctl_installation_dir/include to the following layout?

  include/
    sycl_interface/
        Config/
        Support/
        *.h   /* all *.h files from present include/*.h */
    dpctl/
         dpctl_api.h    /* shallow files containing #include "../../_sycl_queue_api.h" and others */
    pybind11/
         dpctl.h        /* definitions for the C++ classes and casters to/from dpctl Python types */

Let us do these changes in a follow up PR.

@diptorupd diptorupd merged commit 5c3fed5 into IntelPython:master Nov 10, 2021
@diptorupd diptorupd deleted the rename-dpctl-capi branch November 10, 2021 17:37
@AndresGuzman-Ballen
Copy link
Copy Markdown
Contributor

AndresGuzman-Ballen commented Nov 30, 2022

This PR has the devil's mark :O

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@oleksandr-pavlyk oleksandr-pavlyk oleksandr-pavlyk approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@diptorupd @coveralls @oleksandr-pavlyk @AndresGuzman-Ballen