set the last byte in allocated char array to zero.#650
Merged
Conversation
Collaborator
342df7c to
4821508
Compare
diptorupd
reviewed
Nov 3, 2021
4821508 to
7985bfe
Compare
diptorupd
approved these changes
Nov 3, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Set the last byte of new array of chars to 0 to explicitly ensure null-termination.
Noting that the source of the copy,
str.c_str()is always null-terminated (see c++-reference), the terminating character of the destination depends on how many bytes thestrncpy_sactually copies.Feel free to dismiss.