Skip to content

Undid restrictions for on: push triggers#637

Merged
oleksandr-pavlyk merged 1 commit intomasterfrom
undo-workflow-damage
Oct 25, 2021
Merged

Undid restrictions for on: push triggers#637
oleksandr-pavlyk merged 1 commit intomasterfrom
undo-workflow-damage

Conversation

@oleksandr-pavlyk
Copy link
Copy Markdown
Contributor

@oleksandr-pavlyk oleksandr-pavlyk commented Oct 25, 2021 •
edited
Loading

This undoes questionable change from #634, specifically this one:

index 4e70c39c..6b99baf3 100644
--- a/.github/workflows/conda-package.yml
+++ b/.github/workflows/conda-package.yml
@@ -1,6 +1,9 @@
 name: Conda package
 
-on: push
+on:
+  push:
+    branches:
+    tags:
 
 env:
   PACKAGE_NAME: dpctl

The net effect of this change was that workflow was disabled, since branches and tags requirements were never met.

@coveralls
Copy link
Copy Markdown
Collaborator

coveralls commented Oct 25, 2021

Coverage Status

Coverage remained the same at 74.511% when pulling 8cea9a0 on undo-workflow-damage into 9bc9b43 on master.

@oleksandr-pavlyk oleksandr-pavlyk merged commit da13887 into master Oct 25, 2021
@oleksandr-pavlyk oleksandr-pavlyk deleted the undo-workflow-damage branch October 25, 2021 21:11
@PokhodenkoSA
Copy link
Copy Markdown
Contributor

PokhodenkoSA commented Oct 26, 2021

@oleksandr-pavlyk
Could you please provide example of PR where this workflow should start but did not start?

@oleksandr-pavlyk
Copy link
Copy Markdown
Contributor Author

oleksandr-pavlyk commented Oct 26, 2021

#636 was the one. Because it was opened from a fork, the push trigger was not met and windows build and test workflow did not run.

@PokhodenkoSA
Copy link
Copy Markdown
Contributor

PokhodenkoSA commented Oct 26, 2021 •
edited
Loading

It run in author's branch.
image
https://github.com/diptorupd/dpctl/tree/fix/dll_load
image

It is because author pushed to his repository. So it will use his secret tokens and will not upload anything to our anaconda channels.

@PokhodenkoSA
Copy link
Copy Markdown
Contributor

PokhodenkoSA commented Oct 26, 2021 •
edited
Loading

This is a security issue I would like to know how to solve with pull_requests trigger.
I am afraid it will run with our secret tokens.
There is some protections from GitHub like asking for approve before CI run. But I did not investigate it yet with good level of confidence.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@1e-to 1e-to Awaiting requested review from 1e-to

@PokhodenkoSA PokhodenkoSA Awaiting requested review from PokhodenkoSA

1 more reviewer

@diptorupd diptorupd diptorupd approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@oleksandr-pavlyk @coveralls @PokhodenkoSA @diptorupd