Skip to content

dpctl.device_type.host_device -> dpctl.device_type.host#626

Merged
oleksandr-pavlyk merged 1 commit intomasterfrom
fix-test-device-factory
Oct 12, 2021
Merged

dpctl.device_type.host_device -> dpctl.device_type.host#626
oleksandr-pavlyk merged 1 commit intomasterfrom
fix-test-device-factory

Conversation

@oleksandr-pavlyk
Copy link
Copy Markdown
Contributor

@oleksandr-pavlyk oleksandr-pavlyk commented Oct 12, 2021

one stray unrefactored use corrected.

Fixes these two test failures:

FAILED dpctl/tests/test_sycl_device_factory.py::test_get_devices_with_string_args[str_args0] - AttributeError: host_device
FAILED dpctl/tests/test_sycl_device_factory.py::test_get_devices_with_device_type_str[host] - AttributeError: host_device

@coveralls
Copy link
Copy Markdown
Collaborator

coveralls commented Oct 12, 2021

Coverage Status

Coverage increased (+0.4%) to 74.419% when pulling 7b1a61f on fix-test-device-factory into 49ded41 on master.

@oleksandr-pavlyk
Copy link
Copy Markdown
Contributor Author

oleksandr-pavlyk commented Oct 12, 2021

Merging, since only OS compiler workflow runs with host device enabled, but that does not build due to #624 (fixed in #625, but workflow fails pytest due to this issue).

I verified that tests pass locally.

@oleksandr-pavlyk oleksandr-pavlyk merged commit da90ebd into master Oct 12, 2021
@oleksandr-pavlyk oleksandr-pavlyk deleted the fix-test-device-factory branch October 12, 2021 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@diptorupd diptorupd Awaiting requested review from diptorupd

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@oleksandr-pavlyk @coveralls