Add a new utility function to return the device info as a C string object.#620
Merged
diptorupd merged 2 commits intoIntelPython:masterfrom Oct 5, 2021
Merged
Conversation
oleksandr-pavlyk
previously approved these changes
Oct 5, 2021
Contributor
oleksandr-pavlyk
left a comment
There was a problem hiding this comment.
LGTM with small suggestions.
Contributor
|
By the way, the Python API should be changed too, in |
Contributor
Author
Let us add that in #542 |
50f6935 to
38d5a1f
Compare
Collaborator
oleksandr-pavlyk
added a commit
that referenced
this pull request
Oct 6, 2021
no longer needed wit #620 merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The PR adds a new helper function in dpctl_sycl_device_manager called
DPCTLDeviceMgr_GetDeviceInfoStr. The function returns a C string containing the device attributes currently printed out byDPCTLDeviceMgr_PrintDeviceInfo. The change will unblock #542.Added a helper to convert C++ strings to C strings, Reduces code duplication.