Rework the logic in memory's copy_from_device#618
Merged
oleksandr-pavlyk merged 1 commit intomasterfrom Oct 4, 2021
Merged
Conversation
In deciding where a copy from device could be done using a direct call to memcpy, we queried usm type of the source allocation with respect to the context to which the destination allocation was bound. The test was assuming that any answer other than 'unknown' indicated that the USM allocation was known and a memcpy could be called. This did not work well when destination was a host device. For example, this crashed: ``` SYCL_ENABLE_HOST_DEVICE=1 python -m pytest dpctl/tests/test_usm_ndarray_ctor.py::test_to_device ``` It passes now.
Collaborator
Contributor
Author
|
Good to go in. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In deciding where a copy from device could be done using a direct
call to memcpy, we queried usm type of the source allocation with
respect to the context to which the destination allocation was
bound.
The test was assuming that any answer other than 'unknown' indicated
that the USM allocation was known and a memcpy could be called.
This did not work well when destination was a host device. For example,
this crashed:
It passes now.