Use readelf on pi_level_zero library to find exact name of ze_loader#617
Merged
oleksandr-pavlyk merged 1 commit intomasterfrom Oct 4, 2021
Merged
Use readelf on pi_level_zero library to find exact name of ze_loader#617oleksandr-pavlyk merged 1 commit intomasterfrom
oleksandr-pavlyk merged 1 commit intomasterfrom
Conversation
Collaborator
diptorupd
reviewed
Oct 4, 2021
diptorupd
reviewed
Oct 4, 2021
| find_program(READELF_PROG readelf) | ||
| find_program(GREP_PROG grep) | ||
| execute_process( | ||
| COMMAND ${READELF_PROG} -d ${PI_LEVEL_ZERO_LIB} |
Contributor
Author
There was a problem hiding this comment.
I fixed the indentation.
diptorupd
reviewed
Oct 4, 2021
Contributor
diptorupd
left a comment
There was a problem hiding this comment.
Thanks for getting this done. Except for the minor indentation issues that need to be addressed, the PR is good to go.
730e0f6 to
78e85c9
Compare
Store that in include/Config/dpctl_config.h and use the define in dpctl_sycl_program_interface.cpp CMake is running the equivalent of the following ``` readelf -d $DPCPP_ROOT/lib/libpi_level_zero.so | grep libze_loader | grep -Po "libze_loader[^\]]*" libze_loader.so.1 ```
78e85c9 to
55a532e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Store that in include/Config/dpctl_config.h and use the define in
dpctl_sycl_program_interface.cpp
CMake is running the equivalent of the following
This change, together with #603 and #616 make project buildable with OS compiler.