Added tests for constructors with invalid capsules#577
Merged
oleksandr-pavlyk merged 3 commits intomasterfrom Sep 7, 2021
Merged
Added tests for constructors with invalid capsules#577oleksandr-pavlyk merged 3 commits intomasterfrom
oleksandr-pavlyk merged 3 commits intomasterfrom
Conversation
Devices from different platforms can not be used to create a sycl context
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SyclEventdestructor now only calls wait and delete on non-null references.Added tests to check that constructors handle invalid capsules.
Added tests to very that queues from different platforms are unequal, added test for validation that creating
SyclQueuefrom a context and a devices not from that context.Added tests to check that creation of
SyclContextfrom devices from different platforms fails.