Improve coverage of dpctl.__init__ file and other service functions#563
Merged
oleksandr-pavlyk merged 2 commits intomasterfrom Sep 2, 2021
Merged
Improve coverage of dpctl.__init__ file and other service functions#563oleksandr-pavlyk merged 2 commits intomasterfrom
oleksandr-pavlyk merged 2 commits intomasterfrom
Conversation
Collaborator
Contributor
Author
|
@PokhodenkoSA Any idea why this test is failing I think the expectation for it to not contain "unknown" is reasonable, and addition of this test has caught an actual issue. |
Contributor
Author
This is likely caused by using limited depth cloning, specifically use of If we rely on git tags for deducing versions of the product, we should do a full checkout. |
Custom build_py written to enable support for multi-versioned DPCLSyclInterface on Linux need to inherit from versioneer's version of build_py, rather than from setuptools' one to incorporate the step where dpctl/_version.py is overwritten with rendered result based on source tree.
Contributor
Author
|
Turns out this has been a regression I introduced nearly at the beginning of 0.9 development cycle. Now fixed, tests should start passing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added tests to check
DPCTLService_GetDPCPPVersion,dpctl.get_include, anddpctl.__version__.