Fixes #547#548
Merged
oleksandr-pavlyk merged 2 commits intomasterfrom Aug 24, 2021
Merged
Conversation
Property `__sycl_usm_array_interface__` is to use `self.shape` rather
than call _make_int_tuple directly.
```
In [4]: dpt.usm_ndarray(tuple(), dtype='d').__sycl_usm_array_interface__
Out[4]:
{'data': (94536841949184, True),
'shape': (),
'strides': None,
'typestr': '|f8',
'version': 1,
'syclobj': <dpctl.SyclQueue at 0x7f5bbeb3f780>,
'offset': 0}
```
Collaborator
06faa32 to
315b9aa
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #547
Property
__sycl_usm_array_interface__is to useself.shaperatherthan call _make_int_tuple directly.
@shssf @Alexander-Makaryev