Fixed dpctl_config, added dpctl_service.h, .cpp#539
Merged
oleksandr-pavlyk merged 1 commit intomasterfrom Aug 20, 2021
Merged
Conversation
Collaborator
AndresGuzman-Ballen
previously approved these changes
Aug 19, 2021
Contributor
AndresGuzman-Ballen
left a comment
There was a problem hiding this comment.
Pretty cool!
Fixed Config/dpctl_config.h.in so that DPCTL_DPCPP_VERSION preprocessor
variable is now non-empty.
Created `const char * DPCTLService_GetDPCPPVersion(void)` service function
to get the version stored in that preprocessor variable.
This would allow Python to record minimum version requirement for the
DPC++ toolchain runtime.
```
Python 3.7.10 (default, Jun 4 2021, 06:52:02)
Type 'copyright', 'credits' or 'license' for more information
IPython 7.25.0 -- An enhanced Interactive Python. Type '?' for help.
In [1]: import dpctl, ctypes
In [2]: lib = ctypes.cdll.LoadLibrary('dpctl/libDPCTLSyclInterface.so')
In [3]: fn = lib.DPCTLService_GetDPCPPVersion
In [4]: fn.argtypes=[]
In [5]: fn.restype = ctypes.c_char_p
In [6]: fn()
Out[6]: b'2021.3.0'
```
ef53568 to
97bc655
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed Config/dpctl_config.h.in so that
DPCTL_DPCPP_VERSIONpreprocessorvariable is now non-empty.
Created
const char * DPCTLService_GetDPCPPVersion(void)service functionto get the version stored in that preprocessor variable.
This would allow Python to record minimum version requirement for the
DPC++ toolchain runtime.