Skip to content

Remove _init_helper from the SyclEventRaw class #530

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
oleksandr-pavlyk merged 1 commit into from
Aug 17, 2021
Merged

Remove _init_helper from the SyclEventRaw class #530

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions dpctl/_sycl_event.pxd
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,8 +42,6 @@ cdef class _SyclEventRaw:
cdef public class SyclEventRaw(_SyclEventRaw) [object PySyclEventRawObject, type PySyclEventRawType]:
@staticmethod
cdef SyclEventRaw _create (DPCTLSyclEventRef event)
@staticmethod
cdef void _init_helper(_SyclEventRaw event, DPCTLSyclEventRef ERef)
cdef int _init_event_default(self)
cdef int _init_event_from__SyclEventRaw(self, _SyclEventRaw other)
cdef int _init_event_from_SyclEvent(self, SyclEvent event)
Expand Down
8 changes: 3 additions & 5 deletions dpctl/_sycl_event.pyx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,6 +93,8 @@ cdef void _event_capsule_deleter(object o):
)
DPCTLEvent_Delete(ERef)

cdef void _init_helper(_SyclEventRaw event, DPCTLSyclEventRef ERef):
event._event_ref = ERef

cdef class _SyclEventRaw:
""" Python wrapper class for a ``cl::sycl::event``.
Expand All @@ -106,14 +108,10 @@ cdef class SyclEventRaw(_SyclEventRaw):
""" Python wrapper class for a ``cl::sycl::event``.
"""

@staticmethod
cdef void _init_helper(_SyclEventRaw event, DPCTLSyclEventRef ERef):
event._event_ref = ERef

@staticmethod
cdef SyclEventRaw _create(DPCTLSyclEventRef eref):
cdef _SyclEventRaw ret = _SyclEventRaw.__new__(_SyclEventRaw)
SyclEventRaw._init_helper(ret, eref)
_init_helper(ret, eref)
return SyclEventRaw(ret)

cdef int _init_event_default(self):
Expand Down