Skip to content

Add a new DPCTLEvent_GetWaitList function#510

Merged
oleksandr-pavlyk merged 1 commit intoIntelPython:masterfrom
vlad-perevezentsev:event_getwaitlist
Aug 9, 2021
Merged

Add a new DPCTLEvent_GetWaitList function#510
oleksandr-pavlyk merged 1 commit intoIntelPython:masterfrom
vlad-perevezentsev:event_getwaitlist

Conversation

@vlad-perevezentsev
Copy link
Copy Markdown
Collaborator

@vlad-perevezentsev vlad-perevezentsev commented Jul 15, 2021

This PR adds the 'DPCTLEvent_GetWaitList' function which returns the list of events that this event waits for in the dependence graph.

@vlad-perevezentsev vlad-perevezentsev self-assigned this Jul 15, 2021
@vlad-perevezentsev vlad-perevezentsev mentioned this pull request Jul 15, 2021
Closed
9 tasks
@coveralls
Copy link
Copy Markdown
Collaborator

coveralls commented Jul 15, 2021 •
edited
Loading

Coverage Status

Coverage decreased (-0.1%) to 65.046% when pulling b5374bb on vlad-perevezentsev:event_getwaitlist into 893f1f6 on IntelPython:master.

oleksandr-pavlyk
oleksandr-pavlyk reviewed Jul 19, 2021
View reviewed changes
Comment thread dpctl-capi/include/dpctl_sycl_event_interface.h Outdated
diptorupd
diptorupd reviewed Jul 22, 2021
View reviewed changes
Comment thread dpctl-capi/include/dpctl_sycl_event_interface.h Outdated
@vlad-perevezentsev
Copy link
Copy Markdown
Collaborator Author

vlad-perevezentsev commented Jul 28, 2021

@oleksandr-pavlyk I added a Sycl test for function.
It works on SYCL but test fails with DPCTLSyclEvent.

/localdisk/work/vperevez/dp_dparray/dpctl_vlad/dpctl/dpctl-capi/tests/test_sycl_event_interface.cpp:158: Failure
Value of: DPCTLEventVector_Size(EVRef) > 0
  Actual: false
Expected: true

Dependencies passed via ' sycl:: handler::depends_on` are not included in the graph, but are tracked (Compiler LLVM team).
This is a bug. https://jira.devtools.intel.com/browse/CMPLRLLVM-30013

oleksandr-pavlyk
oleksandr-pavlyk suggested changes Aug 2, 2021
View reviewed changes
Comment thread dpctl-capi/include/dpctl_sycl_event_interface.h Outdated
@vlad-perevezentsev vlad-perevezentsev force-pushed the event_getwaitlist branch 3 times, most recently from 97e11c4 to b433ce7 Compare August 4, 2021 11:36
oleksandr-pavlyk
oleksandr-pavlyk reviewed Aug 9, 2021
View reviewed changes
Comment thread dpctl-capi/tests/test_sycl_event_interface.cpp Outdated
oleksandr-pavlyk
oleksandr-pavlyk approved these changes Aug 9, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@oleksandr-pavlyk oleksandr-pavlyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have applied the requested changes and resolved conflicts from earlier merges

@oleksandr-pavlyk oleksandr-pavlyk merged commit e5c50ea into IntelPython:master Aug 9, 2021
@vlad-perevezentsev vlad-perevezentsev deleted the event_getwaitlist branch June 20, 2023 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@diptorupd diptorupd diptorupd left review comments

@oleksandr-pavlyk oleksandr-pavlyk oleksandr-pavlyk approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@vlad-perevezentsev vlad-perevezentsev

Labels

1 - In Progress

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@vlad-perevezentsev @coveralls @diptorupd @oleksandr-pavlyk