Improve test coverage for dpctl_sycl_queue_interface#492
Merged
diptorupd merged 3 commits intoIntelPython:masterfrom Jun 23, 2021
Merged
Improve test coverage for dpctl_sycl_queue_interface#492diptorupd merged 3 commits intoIntelPython:masterfrom
diptorupd merged 3 commits intoIntelPython:masterfrom
Conversation
7f5688a to
50ec561
Compare
50ec561 to
e4fa0be
Compare
Collaborator
c4c3059 to
57488e1
Compare
oleksandr-pavlyk
approved these changes
Jun 23, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improvements to dpctl_c_api
dpctl_sycl_queue_interface.cppdpctl_sycl_program_interface.cppinside the level-zero module creation function.dpctl_sycl_queue_interface.cppintroducing negative test cases.Note - Unit tests for
DPCTLQueue_Memcpyand family are not added here. I will be adding them in a separate PR.