Fixes the addressof_ref function of SyclContext and improves unit tests.#488
Merged
diptorupd merged 3 commits intoIntelPython:masterfrom Jun 2, 2021
Merged
Fixes the addressof_ref function of SyclContext and improves unit tests.#488diptorupd merged 3 commits intoIntelPython:masterfrom
diptorupd merged 3 commits intoIntelPython:masterfrom
Conversation
added 2 commits
June 1, 2021 21:52
- Added unit tests for __name__, __repr__, addressof_ref
- Added an additional negative test for __eq__
- Removed test fixtures for device members. These members are
already tested for SyclDevice.
oleksandr-pavlyk
previously approved these changes
Jun 2, 2021
oleksandr-pavlyk
approved these changes
Jun 2, 2021
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #484
addressof_reffunction ofSyclContextthat was causing anAttributeErrorand added a unit test for the member.SyclContextand removed the duplicate tests that were copied over fromSyclDevice.