Skip to content

Fix SDL check#487

Merged
oleksandr-pavlyk merged 1 commit intomasterfrom
try-fixing-sdl-loner
Jun 2, 2021
Merged

Fix SDL check#487
oleksandr-pavlyk merged 1 commit intomasterfrom
try-fixing-sdl-loner

Conversation

@oleksandr-pavlyk
Copy link
Copy Markdown
Contributor

@oleksandr-pavlyk oleksandr-pavlyk commented Jun 2, 2021

Follow DPCTLDevice_CreateFromSelector which passes the check.

This should fix an issue from SAT-4170:

Possible memory leak. Dynamic memory stored in 'P' allocated through function 'new' at line 84 can be lost at line 88

@coveralls
Copy link
Copy Markdown
Collaborator

Coverage Status

Coverage decreased (-0.03%) to 60.889% when pulling 5baf591 on try-fixing-sdl-loner into 0951961 on master.

@oleksandr-pavlyk oleksandr-pavlyk changed the title Follow DPCTLDevice_CreateFromSelector which passes the check Fix SDL check Jun 2, 2021
Copy link
Copy Markdown
Contributor

@diptorupd diptorupd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@oleksandr-pavlyk oleksandr-pavlyk merged commit 4513a1d into master Jun 2, 2021
diptorupd pushed a commit to diptorupd/dpctl that referenced this pull request Jun 22, 2021
@oleksandr-pavlyk oleksandr-pavlyk deleted the try-fixing-sdl-loner branch August 20, 2021 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants