Skip to content

Added test for as_usm_memory#449

Merged
oleksandr-pavlyk merged 1 commit intomasterfrom
add-as-usm-memory-tests
May 18, 2021
Merged

Added test for as_usm_memory#449
oleksandr-pavlyk merged 1 commit intomasterfrom
add-as-usm-memory-tests

Conversation

@oleksandr-pavlyk
Copy link
Copy Markdown
Contributor

@oleksandr-pavlyk oleksandr-pavlyk commented May 18, 2021

This test checks for conformance to sycl_usm_array_interface spect from Wiki

@oleksandr-pavlyk
Added test for as_usm_memory
a9ee9f4 
This test checks for conformance to __sycl_usm_array_interface__ spect from Wiki
@oleksandr-pavlyk oleksandr-pavlyk force-pushed the add-as-usm-memory-tests branch from 27b474d to a9ee9f4 Compare May 18, 2021 19:02
@oleksandr-pavlyk oleksandr-pavlyk merged commit 2ed58e2 into master May 18, 2021
@oleksandr-pavlyk oleksandr-pavlyk deleted the add-as-usm-memory-tests branch May 18, 2021 20:32
@oleksandr-pavlyk
Copy link
Copy Markdown
Contributor Author

oleksandr-pavlyk commented May 18, 2021

CI is green, merging.

oleksandr-pavlyk added a commit that referenced this pull request May 26, 2021
@oleksandr-pavlyk
Removing get_usm_pointer_type function
4f03b9b 
It was added in early iterations of #449 but then
superseded by as_usm_memory, and the get_usm_pointer_type
should have been removed.

The reasoning for the removal can be found in comments
left in #449
@oleksandr-pavlyk oleksandr-pavlyk mentioned this pull request May 26, 2021
Merged
oleksandr-pavlyk added a commit that referenced this pull request May 26, 2021
@oleksandr-pavlyk
Removing get_usm_pointer_type function (#474)
612fe24 
It was added in early iterations of #449 but then
superseded by as_usm_memory, and the get_usm_pointer_type
should have been removed.

The reasoning for the removal can be found in comments
left in #449
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@diptorupd diptorupd Awaiting requested review from diptorupd

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@oleksandr-pavlyk