Use size_t instead of Py_ssize_t to fit device USM pointer#405
Merged
oleksandr-pavlyk merged 1 commit intomasterfrom Apr 27, 2021
Merged
Use size_t instead of Py_ssize_t to fit device USM pointer#405oleksandr-pavlyk merged 1 commit intomasterfrom
oleksandr-pavlyk merged 1 commit intomasterfrom
Conversation
Also to avoid formatting of the USM-device pointer as a negative hex value
de68712 to
fb3de0c
Compare
diptorupd
approved these changes
Apr 27, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use
size_tinstead ofPy_ssize_tto represent USM pointer as Python object. This allows_USMBufferDataclass to understand SUAI with device-pointers.Also to avoid formatting of the USM-device pointer as a negative hex value, e.g. format
dpctl.memory.MemoryUSMDevice(32).