Fix tests which fail if GPU is not available (only CPU is available)#359
Merged
PokhodenkoSA merged 2 commits intomasterfrom Apr 2, 2021
Merged
Fix tests which fail if GPU is not available (only CPU is available)#359PokhodenkoSA merged 2 commits intomasterfrom
PokhodenkoSA merged 2 commits intomasterfrom
Conversation
| ctx1 = dpctl.SyclContext("gpu") | ||
| ctx0 = dpctl.SyclContext("gpu") | ||
| except dpctl.SyclQueueCreationError: | ||
| except ValueError: |
Contributor
There was a problem hiding this comment.
This is good. I think we may as well introduce SyclContextCreationError and use that, for symmetry,
oleksandr-pavlyk
approved these changes
Apr 2, 2021
Contributor
Author
|
There are also a lot of failed tests when CPU is not available too. |
Contributor
|
@PokhodenkoSA @oleksandr-pavlyk We can use |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains several fixes for tests which should be skipped if GPU is not available but they was not skipped.
dpctl.SyclContext("gpu")raisesValueError. It seems that catchingdpctl.SyclQueueCreationErroris copy/past error.test_context_can_be_used_in_queue2exception was not caught.TestGetCurrentDeviceuses contextopencl:gpu:0in several tests so it should be skipped if GPU is not available.