Fix/crashes reported in 345 344#349
Merged
diptorupd merged 3 commits intoIntelPython:masterfrom Apr 1, 2021
Merged
Conversation
Contributor
Author
|
I added checks to skip tests when a device does not exist. However, if current device does not exist then that is flagged as a failed test case. |
oleksandr-pavlyk
approved these changes
Apr 1, 2021
PokhodenkoSA
suggested changes
Apr 1, 2021
Contributor
PokhodenkoSA
left a comment
There was a problem hiding this comment.
C API should not throw exceptions at all. We should catch all exceptions.
Comment on lines
+87
to
+89
| } catch (runtime_error const &re) { | ||
| std::cerr << re.what() << '\n'; | ||
| return nullptr; |
Contributor
There was a problem hiding this comment.
Please, do catch(...) finally. Any uncatched exception will break C API interface.
Contributor
Author
There was a problem hiding this comment.
Let us do that as a follow up along with the overall work needed to improve error handling (#35).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #345
Closes #344
Supersedes #348