Add a version requirement for dpcpp inside CMakeList.txt.#339
Merged
diptorupd merged 2 commits intoIntelPython:masterfrom Apr 2, 2021
Merged
Add a version requirement for dpcpp inside CMakeList.txt.#339diptorupd merged 2 commits intoIntelPython:masterfrom
diptorupd merged 2 commits intoIntelPython:masterfrom
Conversation
Contributor
Author
|
@oleksandr-pavlyk There are two more things that we need to properly address before this is ready to be merged:
|
Contributor
|
The cmake 3.20 supports oneAPI compiler as IntelLLVM, see New In 3.20#Compilers. Perhaps this could be leveraged to support both custom build of open-source LLVM with SYCL support and dpcpp. We can also institute a shallow dpctl init-time check that the DCPPP run-time meets functional requirements, i.e. can ascertain that two devices created with the same selector are equal, and raise RuntimeError otherwise. |
oleksandr-pavlyk
approved these changes
Apr 1, 2021
diptorupd
pushed a commit
to diptorupd/dpctl
that referenced
this pull request
Apr 2, 2021
…n#339) * Add a version requirement for dpcpp inside CMakeList.txt. * Add dpcpp_cpp_rt version requirement to dpctl.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.