Merged
Conversation
8849425 to
e8a5068
Compare
Contributor
|
This is not right: In [1]: import dpctl
In [2]: dpctl.SyclDevice("gpu")
Out[2]: <dpctl.SyclDevice at 0x7fd76edb44b0>
In [3]: dpctl.SyclQueue(dpctl.SyclDevice("gpu"))
Out[3]: <dpctl._sycl_queue.SyclQueue at 0x7fd7641299b0>
In [4]: Out[3].get_sycl_device() # UNEXPECTED: expecting to see SyclDevice, like in Out[2], but getting None
In [5]: !git status
On branch feature/device_selectors
Your branch is up to date with 'dipto/feature/device_selectors'.
nothing to commit, working tree clean
In [6]: !git log -1 --format=%H
28022afb8df19f46a7e488677dfb6f13c988c802 |
Contributor
Author
|
@oleksandr-pavlyk Needs more work. Something I did wrong results in |
Contributor
Author
|
@oleksandr-pavlyk I think this is good to go. Unfortunately the PR became way too huge than I had intended it to be, but will be great if you take a pass before we merge. |
99bc335 to
d7036d6
Compare
added 8 commits
March 3, 2021 22:21
- Add a new dpctl_sycl_device_manager module to store a
cache of root devices along with a cached context per
device.
- The device manager includes functions to get a vector of
devices and the number of root devices of a specific type
and backend combination.
- Move the DPCTLDevice_DumpInfo() to a new module called
dpctl_sycl_device_manager, and rename it to
DPCTLDeviceMgr_PrintDeviceInfo().
- Introduce a new _sycl_device_factory module in the Python API.
- Move device selector functions to the _sycl_device_factory
module.
- Add functions to get list of SYCL devies in dpctl.
d7036d6 to
a8e49c5
Compare
oleksandr-pavlyk
approved these changes
Mar 8, 2021
Contributor
oleksandr-pavlyk
left a comment
There was a problem hiding this comment.
Commits from this PR are also included in feature/queue_manager_v2.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #146
Closes #248
Closes #313
Various improvements to device management.
_sycl_device_factorymodule to easily get the list of available devices in Python from SYCL.