Skip to content

Relax hard pinning for build time compiler#1752

Merged
oleksandr-pavlyk merged 1 commit intomasterfrom
relax-compiler-pinning
Jul 23, 2024
Merged

Relax hard pinning for build time compiler#1752
oleksandr-pavlyk merged 1 commit intomasterfrom
relax-compiler-pinning

Conversation

@oleksandr-pavlyk
Copy link
Copy Markdown
Contributor

@oleksandr-pavlyk oleksandr-pavlyk commented Jul 23, 2024

This PR replaces hard pinning of compiler version in build environment to >=.

This allows internal CI to build with future version of compiler as well.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you opening the PR as a draft?

This allows internal CI to build with future version
of compiler as well.
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jul 23, 2024

Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞

@coveralls
Copy link
Copy Markdown
Collaborator

Coverage Status

coverage: 87.965%. remained the same
when pulling cd3e530 on relax-compiler-pinning
into 5164f99 on master.

@github-actions
Copy link
Copy Markdown

Array API standard conformance tests for dpctl=0.18.0dev0=py310ha798474_158 ran successfully.
Passed: 894
Failed: 1
Skipped: 119

Copy link
Copy Markdown
Collaborator

@antonwolfy antonwolfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tests in internal CI are passing now. Thank you @oleksandr-pavlyk

@oleksandr-pavlyk oleksandr-pavlyk merged commit 7450558 into master Jul 23, 2024
@oleksandr-pavlyk oleksandr-pavlyk deleted the relax-compiler-pinning branch July 23, 2024 13:03
Copy link
Copy Markdown
Contributor

@ZzEeKkAa ZzEeKkAa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @oleksandr-pavlyk . I could have missed it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants