Skip to content

Require 2024.2.0 DPC++ compiler#1739

Merged
oleksandr-pavlyk merged 2 commits intomasterfrom
backport-compiler-pinning
Jul 19, 2024
Merged

Require 2024.2.0 DPC++ compiler#1739
oleksandr-pavlyk merged 2 commits intomasterfrom
backport-compiler-pinning

Conversation

@oleksandr-pavlyk
Copy link
Copy Markdown
Contributor

Bump up required compiler

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you opening the PR as a draft?

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jul 18, 2024

Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞

@coveralls
Copy link
Copy Markdown
Collaborator

coveralls commented Jul 18, 2024

Coverage Status

coverage: 87.953%. remained the same
when pulling c0df9e4 on backport-compiler-pinning
into d191e97 on master.

@github-actions
Copy link
Copy Markdown

Array API standard conformance tests for dpctl=0.18.0dev0=py310ha798474_132 ran successfully.
Passed: 894
Failed: 15
Skipped: 105

antonwolfy
antonwolfy previously approved these changes Jul 19, 2024
Copy link
Copy Markdown
Collaborator

@antonwolfy antonwolfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change is LGM, but I left some minor comments which can be addressed by other PR is applicable.

Comment thread conda-recipe/meta.yaml
Comment thread conda-recipe/meta.yaml
@github-actions
Copy link
Copy Markdown

Array API standard conformance tests for dpctl=0.18.0dev0=py310ha798474_135 ran successfully.
Passed: 894
Failed: 1
Skipped: 119

Copy link
Copy Markdown
Collaborator

@antonwolfy antonwolfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @oleksandr-pavlyk, LGTM!

@oleksandr-pavlyk oleksandr-pavlyk merged commit 28a231e into master Jul 19, 2024
@oleksandr-pavlyk oleksandr-pavlyk deleted the backport-compiler-pinning branch July 19, 2024 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants