Fix for crash reported in gh-1654#1676
Merged
oleksandr-pavlyk merged 1 commit intomasterfrom May 14, 2024
Merged
Conversation
This also fixes a crash in dpt.sort on CUDA device for sorting of 256 elements of floating point numbers.
|
Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞 |
|
Array API standard conformance tests for dpctl=0.17.0dev0=py310h15de555_336 ran successfully. |
Collaborator
ndgrigorian
approved these changes
May 13, 2024
Collaborator
ndgrigorian
left a comment
There was a problem hiding this comment.
CUDA tests pass, so LGTM. Nice fix to get in this version.
Contributor
Author
|
The example that was crashing on CUDA device: import dpctl.tensor as dpt
x = dpt.arange(256, dtype="i4", device="cuda:gpu")
dpt.sort(x, descending=True) # crash |
antonwolfy
approved these changes
May 14, 2024
Collaborator
antonwolfy
left a comment
There was a problem hiding this comment.
I checked locally DPNP tests relating to sort and argsort functions and they passed without any issue.
Also the gh-issue reported as #1676 isn't reproduced anymore locally for me with the proposed dpctl fix.
Thank you @oleksandr-pavlyk for resolving the issue!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes gh-1654
The reason behind the crash was out of bound access to shared local memory accessor.
This also fixes a crash in
dpt.sorton CUDA device for sorting of 256 elements of floating point numbers.