Skip to content

Initialize UAR_BYTE_ and UAR_UBYTE_ in dpctl_capi#1665

Merged
ndgrigorian merged 1 commit intomasterfrom
fix-uninitialized-capi-typenums
May 6, 2024
Merged

Initialize UAR_BYTE_ and UAR_UBYTE_ in dpctl_capi#1665
ndgrigorian merged 1 commit intomasterfrom
fix-uninitialized-capi-typenums

Conversation

@ndgrigorian
Copy link
Copy Markdown
Collaborator

This PR fixes two uninitialized typenums in dpctl_capi for UAR_BYTE_ and UAR_UBYTE_.

It was noticed during extension writing that these variables are initialized to -1 and never set to the proper values.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you opening the PR as a draft?

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 6, 2024

Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞

@coveralls
Copy link
Copy Markdown
Collaborator

Coverage Status

coverage: 87.892%. remained the same
when pulling f38b8a8 on fix-uninitialized-capi-typenums
into 0cb2181 on master.

Copy link
Copy Markdown
Contributor

@oleksandr-pavlyk oleksandr-pavlyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 6, 2024

Array API standard conformance tests for dpctl=0.17.0dev0=py310h15de555_327 ran successfully.
Passed: 882
Failed: 10
Skipped: 92

@ndgrigorian ndgrigorian merged commit 229b93f into master May 6, 2024
@ndgrigorian ndgrigorian deleted the fix-uninitialized-capi-typenums branch May 6, 2024 20:06
@ndgrigorian ndgrigorian mentioned this pull request May 15, 2024
6 tasks
oleksandr-pavlyk added a commit that referenced this pull request May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants