Fix compiling for CUDA with 2024.1 compiler#1630
Merged
oleksandr-pavlyk merged 2 commits intomasterfrom Apr 3, 2024
Merged
Conversation
…floor` with `sycl` variants This is necessitated by issues linking when building for CUDA using 2024.1 compiler
Collaborator
Author
|
@oleksandr-pavlyk |
|
Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞 |
Collaborator
|
Array API standard conformance tests for dpctl=0.17.0dev0=py310h15de555_162 ran successfully. |
The issue that was being work arround has been fixed in 2024.1 compiler
Contributor
|
I have pushed a commit to remove the work-around. Local tests passed. |
|
Array API standard conformance tests for dpctl=0.17.0dev0=py310h15de555_163 ran successfully. |
| #ifdef USE_SYCL_FOR_COMPLEX_TYPES | ||
| return exprm_ns::abs(exprm_ns::complex<realT>(z)); | ||
| #else | ||
| return std::hypot(std::real(z), std::imag(z)); |
Contributor
There was a problem hiding this comment.
Suggested change
| return std::hypot(std::real(z), std::imag(z)); | |
| return std::hypot(x, y); |
oleksandr-pavlyk
approved these changes
Apr 3, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using the 2024.1 compiler and building with
DPCTL_TARGET_CUDA=1fails due to unrecognized symbols in elementwise functions likefabs,fabsf,copysign, andfloorfrom the C++ std namespace.This PR proposes replacing the non-working symbols with their Sycl namespace equivalents.