Correction to dpctl.tensor.tile for scalar input and empty repetitions#1628
Merged
ndgrigorian merged 1 commit intomasterfrom Apr 1, 2024
Merged
Correction to dpctl.tensor.tile for scalar input and empty repetitions#1628ndgrigorian merged 1 commit intomasterfrom
dpctl.tensor.tile for scalar input and empty repetitions#1628ndgrigorian merged 1 commit intomasterfrom
Conversation
… `repetitions` Previously, this case would return a 1D array of size 1, which did not match Numpy or the array API spec's expected behavior
oleksandr-pavlyk
approved these changes
Apr 1, 2024
Contributor
oleksandr-pavlyk
left a comment
There was a problem hiding this comment.
Look good to me! Thank you @ndgrigorian
|
Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞 |
Collaborator
|
Array API standard conformance tests for dpctl=0.17.0dev0=py310h15de555_161 ran successfully. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug in
tilewhere if the input is 0D andrepetitionsis empty, instead of a copying a scalar input and returning a scalar, a 1D array of size 1 would be returned instead.Per the array API spec and Numpy, this is incorrect behavior.
Resolves #1627