Removed use of std::move in DPCTLDeviceMgr_GetCachedContext#1573
Merged
oleksandr-pavlyk merged 1 commit intomasterfrom Mar 1, 2024
Merged
Removed use of std::move in DPCTLDeviceMgr_GetCachedContext#1573oleksandr-pavlyk merged 1 commit intomasterfrom
oleksandr-pavlyk merged 1 commit intomasterfrom
Conversation
Use of std::move destroys the context saved in the cache, negating existance of this cache, but also setting the code up for possible silent failures.
|
Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞 |
Collaborator
|
Array API standard conformance tests for dpctl=0.17.0dev0=py310h15de555_43 ran successfully. |
ndgrigorian
approved these changes
Feb 29, 2024
6 tasks
oleksandr-pavlyk
added a commit
that referenced
this pull request
Mar 27, 2024
Backport gh-1573 to 0.16.x maintenance branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use of
std::movedestroys the context saved in the cache, negating existence of this cache, but also setting the code up for possible silent failures.