Skip to content

Implements log2 and log10#1267

Merged
ndgrigorian merged 3 commits intomasterfrom
elementwise-functions-log-variants
Jul 4, 2023
Merged

Implements log2 and log10#1267
ndgrigorian merged 3 commits intomasterfrom
elementwise-functions-log-variants

Conversation

@ndgrigorian
Copy link
Copy Markdown
Collaborator

@ndgrigorian ndgrigorian commented Jun 29, 2023

This PR implements elementwise functions dpctl.tensor.log2, dpctl.tensor.log10, and dpctl.tensor.logaddexp.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you opening the PR as a draft?

@ndgrigorian ndgrigorian force-pushed the elementwise-functions-log-variants branch from 9842cdd to 19663c9 Compare June 29, 2023 08:45
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jun 29, 2023

View rendered docs @ https://intelpython.github.io/dpctl/pulls/1267/index.html

@coveralls
Copy link
Copy Markdown
Collaborator

coveralls commented Jun 29, 2023 •
edited
Loading

Coverage Status

coverage: 83.287% (+0.005%) from 83.282% when pulling c90e5d5 on elementwise-functions-log-variants into 7510d7e on master.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jun 29, 2023

Array API standard conformance tests for dpctl=0.14.5dev0=py310h7bf5fec_5 ran successfully.
Passed: 410
Failed: 590
Skipped: 119

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jun 29, 2023

Array API standard conformance tests for dpctl=0.14.5dev0=py310h7bf5fec_5 ran successfully.
Passed: 408
Failed: 592
Skipped: 119

@ndgrigorian ndgrigorian changed the title Implements log2, log10, and logaddexp Implements log2 and log10 Jul 4, 2023
@ndgrigorian ndgrigorian force-pushed the elementwise-functions-log-variants branch from 19663c9 to d59f6c0 Compare July 4, 2023 09:41
@ndgrigorian ndgrigorian marked this pull request as ready for review July 4, 2023 10:02
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jul 4, 2023

Array API standard conformance tests for dpctl=0.14.5dev0=py310h7bf5fec_9 ran successfully.
Passed: 415
Failed: 585
Skipped: 119

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jul 4, 2023

Array API standard conformance tests for dpctl=0.14.5dev0=py310h7bf5fec_10 ran successfully.
Passed: 414
Failed: 586
Skipped: 119

vlad-perevezentsev
vlad-perevezentsev previously approved these changes Jul 4, 2023
View reviewed changes
Copy link
Copy Markdown
Collaborator

@vlad-perevezentsev vlad-perevezentsev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
thanks @ndgrigorian

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jul 4, 2023

Array API standard conformance tests for dpctl=0.14.5dev0=py310h7bf5fec_16 ran successfully.
Passed: 448
Failed: 552
Skipped: 119

@ndgrigorian ndgrigorian merged commit bc59de9 into master Jul 4, 2023
@ndgrigorian ndgrigorian deleted the elementwise-functions-log-variants branch July 4, 2023 18:30
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jul 4, 2023

Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jul 4, 2023

Array API standard conformance tests for dpctl=0.14.5dev0=py310h7bf5fec_13 ran successfully.
Passed: 449
Failed: 551
Skipped: 119

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vlad-perevezentsev vlad-perevezentsev vlad-perevezentsev left review comments

@antonwolfy antonwolfy Awaiting requested review from antonwolfy antonwolfy is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ndgrigorian @coveralls @vlad-perevezentsev