Skip to content

Implementation of less_equal, greater, greater_equal for dpctl.tensor#1239

Merged
ndgrigorian merged 5 commits intoIntelPython:masterfrom
vlad-perevezentsev:comparison_funcs
Jun 13, 2023
Merged

Implementation of less_equal, greater, greater_equal for dpctl.tensor#1239
ndgrigorian merged 5 commits intoIntelPython:masterfrom
vlad-perevezentsev:comparison_funcs

Conversation

@vlad-perevezentsev
Copy link
Copy Markdown
Collaborator

This PR adds comparison functions such as less_equal ,greater and greater_equal for dpctl.tensor and tests for them

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you opening the PR as a draft?

@coveralls
Copy link
Copy Markdown
Collaborator

coveralls commented Jun 13, 2023

Coverage Status

coverage: 84.11% (+0.007%) from 84.103% when pulling 20cbd36 on vlad-perevezentsev:comparison_funcs into 0185fa9 on IntelPython:master.

Copy link
Copy Markdown
Collaborator

@ndgrigorian ndgrigorian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @vlad-perevezentsev!

@ndgrigorian ndgrigorian merged commit 43f3b7b into IntelPython:master Jun 13, 2023
@github-actions
Copy link
Copy Markdown

Array API standard conformance tests for dpctl=0.14.3dev3=py310h7bf5fec_40 ran successfully.
Passed: 359
Failed: 641
Skipped: 119

@vlad-perevezentsev vlad-perevezentsev deleted the comparison_funcs branch June 20, 2023 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants