Fix dpctl.tensor.sum for support zero-dimensional array#1238
Merged
ndgrigorian merged 1 commit intoIntelPython:masterfrom Jun 13, 2023
Merged
Fix dpctl.tensor.sum for support zero-dimensional array#1238ndgrigorian merged 1 commit intoIntelPython:masterfrom
ndgrigorian merged 1 commit intoIntelPython:masterfrom
Conversation
Collaborator
|
Array API standard conformance tests for dpctl=0.14.3dev3=py310h7bf5fec_33 ran successfully. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR changes a bit the behavior for
dpctl.tensor.sumfunction for scalars.The previous implementation always returned
dpt.zerosfor zero-dimensions of the input array and worked incorrectly for scalars. According to the Python Array API:If N is 0, the sum is 0 (i.e., the empty sum)[sum].Now if
dpctl.tensor.sumtakes a scalar it returns a scalar has the same behavior as numpy