Skip to content

Implementation of expm1, log, and log1p#1218

Merged
ndgrigorian merged 3 commits intomasterfrom
elementwise-expm1-log1p-log
May 30, 2023
Merged

Implementation of expm1, log, and log1p#1218
ndgrigorian merged 3 commits intomasterfrom
elementwise-expm1-log1p-log

Conversation

@ndgrigorian
Copy link
Copy Markdown
Collaborator

This PR implements dpctl.tensor.expm1, dpctl.tensor.log, and dpctl.tensor.log1p.
Also adds tests, including tests for real and complex variants where appropriate

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you opening the PR as a draft?

- Also adds tests for real and complex variants where appropriate
@github-actions
Copy link
Copy Markdown

@coveralls
Copy link
Copy Markdown
Collaborator

coveralls commented May 26, 2023

Coverage Status

Coverage: 84.019% (+0.008%) from 84.012% when pulling 190e5d3 on elementwise-expm1-log1p-log into 521867b on master.

@github-actions
Copy link
Copy Markdown

Array API standard conformance tests for dpctl=0.14.3dev3=py310h7bf5fec_2 ran successfully.
Passed: 257
Failed: 743
Skipped: 116

Comment thread dpctl/tensor/libtensor/include/kernels/elementwise_functions/log1p.hpp Outdated
@github-actions
Copy link
Copy Markdown

Array API standard conformance tests for dpctl=0.14.3dev3=py310h7bf5fec_3 ran successfully.
Passed: 258
Failed: 742
Skipped: 116

vtavana
vtavana previously approved these changes May 30, 2023
Comment thread dpctl/tensor/libtensor/include/kernels/elementwise_functions/log1p.hpp Outdated
Comment thread dpctl/tensor/libtensor/include/kernels/elementwise_functions/log1p.hpp Outdated
@github-actions
Copy link
Copy Markdown

Array API standard conformance tests for dpctl=0.14.3dev3=py310h7bf5fec_4 ran successfully.
Passed: 258
Failed: 742
Skipped: 116

@ndgrigorian ndgrigorian merged commit 3a063f2 into master May 30, 2023
@github-actions
Copy link
Copy Markdown

Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞

@github-actions
Copy link
Copy Markdown

Array API standard conformance tests for dpctl=0.14.3dev3=py310h7bf5fec_4 ran successfully.
Passed: 259
Failed: 741
Skipped: 116

@ndgrigorian ndgrigorian deleted the elementwise-expm1-log1p-log branch July 27, 2023 01:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants