Initial check-in of some unary and binary elementwise functions by oleksandr-pavlyk · Pull Request #1203 · IntelPython/dpctl

oleksandr-pavlyk · 2023-05-08T21:51:56Z

This is a draft PR to review/refine implementation of elementwise functions in dpctl.tensor.

This checks in implementations of dpctl.tensor.add, dpctl.tensor.isnan, dpctl.tensor.cos and dpctl.tensor.abs, dpctl.tensor.isinf, dpctl.tensor.isfinite, and dpctl.tensor.divide, and dpctl.tensor.equal.

Have you provided a meaningful PR description?
Have you added a test, reproducer or referred to an issue with a reproducer?
Have you tested your changes locally for CPU and GPU devices?
Have you made sure that new changes do not introduce compiler warnings?
Have you checked performance impact of proposed changes?
If this PR is a work in progress, are you opening the PR as a draft?

github-actions · 2023-05-08T22:09:05Z

View rendered docs @ https://intelpython.github.io/dpctl/pulls/1203/index.html

Corrected/added checks for validity of sub-groups reads/writes. Added -fno-approx-func flag to compile element-wise functions, as well as -fno-finite-math-only flag. Fixed test_cos_order test to account for NumPy using float16 for intermediate computations for inputs of type "i1", but CPU RT does not support float16.

coveralls · 2023-05-09T15:04:43Z

Coverage: 84.034% (+0.6%) from 83.41% when pulling 62f2d46 on feature/elementwise-functions into 634348b on master.

github-actions · 2023-05-09T15:23:50Z

Array API standard conformance tests for dpctl=0.14.3dev1=py310h76be34b_51 ran successfully.
Passed: 162
Failed: 838
Skipped: 116

github-actions · 2023-05-09T16:27:31Z

Array API standard conformance tests for dpctl=0.14.3dev1=py310h76be34b_52 ran successfully.
Passed: 162
Failed: 838
Skipped: 116

github-actions · 2023-05-10T22:19:17Z

Array API standard conformance tests for dpctl=0.14.3dev1=py310h76be34b_54 ran successfully.
Passed: 162
Failed: 838
Skipped: 116

…rided unary functors Added tests,

oleksandr-pavlyk · 2023-05-14T21:36:21Z

The build failure occurs due to use of int std::isinf(double x). When compiling this with DPC++ and system's GCC 9.4 and sysroot, it goes through fine, but when compiling it with DPC++ and conda GCC 11.2 (or 12.2) and conda's sysroot, it fails to compile.

Using sycl::isinf could be a work-around, but tests fail due to apparent bug in OpenCL CPU RT.

…el/tools to get it until it comes online from conda-forge

This calls crashing test_tensor_elementwise under gdb in batch mode in CI. gdb call exit code is ignored

…ns-use-2.28

…nused)

…-functions

github-actions · 2023-05-17T01:34:53Z

Array API standard conformance tests for dpctl=0.14.3dev1=py310h76be34b_82 ran successfully.
Passed: 210
Failed: 790
Skipped: 116

github-actions · 2023-05-18T21:06:54Z

Array API standard conformance tests for dpctl=0.14.3dev1=py310h76be34b_103 ran successfully.
Passed: 228
Failed: 772
Skipped: 116

github-actions · 2023-05-18T21:38:55Z

Array API standard conformance tests for dpctl=0.14.3dev1=py310h76be34b_104 ran successfully.
Passed: 227
Failed: 773
Skipped: 116

github-actions · 2023-05-18T22:35:41Z

Array API standard conformance tests for dpctl=0.14.3dev1=py310h76be34b_105 ran successfully.
Passed: 228
Failed: 772
Skipped: 116

github-actions · 2023-05-19T03:38:56Z

Array API standard conformance tests for dpctl=0.14.3dev1=py310h76be34b_106 ran successfully.
Passed: 227
Failed: 773
Skipped: 116

Also consolidated various *impl_fn_ptr_t which were common among unary functions, and among binary functions into common reused types.

github-actions · 2023-05-20T04:13:42Z

Array API standard conformance tests for dpctl=0.14.3dev1=py310h76be34b_107 ran successfully.
Passed: 228
Failed: 772
Skipped: 116

Also ensure that test_add_order exercises non-same dtypes to improve coverage.

…ns-out-keyword Feature/elementwise functions out keyword

github-actions · 2023-05-21T00:50:55Z

Array API standard conformance tests for dpctl=0.14.3dev1=py310h76be34b_114 ran successfully.
Passed: 228
Failed: 772
Skipped: 116

github-actions · 2023-05-22T17:55:33Z

Array API standard conformance tests for dpctl=0.14.3dev1=py310h76be34b_115 ran successfully.
Passed: 227
Failed: 773
Skipped: 116

ndgrigorian

I've looked over the out keyword addition and tested it out.
I think this is ready to be merged. This will be a great addition.

github-actions · 2023-05-22T19:09:00Z

Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞

github-actions · 2023-05-22T19:56:21Z

Array API standard conformance tests for dpctl=0.14.3dev1=py310h76be34b_115 ran successfully.
Passed: 228
Failed: 772
Skipped: 116

Initial check-in of elementwise functions: abs/cos/isnan/add

2d2bfc2

oleksandr-pavlyk requested a review from ndgrigorian May 8, 2023 22:54

Fixed typo in CMakeLists.txt cause -fno-apporox-func to be ignored

70615d1

oleksandr-pavlyk added 2 commits May 10, 2023 13:37

Fixing typos discovered by added tests

a947b3a

Added tests to increase coverage of elementwise functions

872f372

oleksandr-pavlyk and others added 6 commits May 11, 2023 16:12

Implemented isinf, isfinite, reused templates to define Contig and St…

6d71e46

…rided unary functors Added tests,

Added missing include statements

049b523

Debug: Set -H when compiling elementwise_functions.cpp

b49744a

Added -fno-approx-func and -fno-finite-math-only

56b134c

Implements dpctl.tensor.sqrt

4952132

Removed unneeded temporaries

1798bf2

oleksandr-pavlyk changed the title ~~Initial check-in of elementwise functions: abs/cos/isnan/add~~ Initial check-in of elementwise functions: abs/cos/isnan/add/isinf/isfinite May 13, 2023

oleksandr-pavlyk added 3 commits May 15, 2023 05:25

Use sycl::isinf for vec, but std::inf for scalars

d2c9aa4

Removed -H as it is not helpful, but verbose

ca46b1b

Update meta.yaml to require sysroot_linux-64 >=2.28, and use dppy/lab…

88e8931

…el/tools to get it until it comes online from conda-forge

oleksandr-pavlyk mentioned this pull request May 16, 2023

Try using sysroot 2.28 #1208

Merged

6 tasks

oleksandr-pavlyk added 6 commits May 16, 2023 13:39

Use verbose lsplatform in run_test.sh

95a8142

Added gdb call in test_linux as a separate step

b1495a2

This calls crashing test_tensor_elementwise under gdb in batch mode in CI. gdb call exit code is ignored

Merge pull request #1208 from IntelPython/feature/elementwise-functio…

58ff5be

…ns-use-2.28

Created templates for binary functions too, applied for addition

f3535f1

Added NullPtrTable<FunPtrT> and NullPtrVector<FunPtrT> classes (yet u…

73e979d

…nused)

Merge remote-tracking branch 'origin/master' into feature/elementwise…

300cc47

…-functions

ndgrigorian reviewed May 18, 2023

View reviewed changes

Comment thread dpctl/tensor/libtensor/source/elementwise_functions.hpp Outdated

Use MemoryOverlap

c6ef075

ndgrigorian reviewed May 18, 2023

View reviewed changes

Comment thread dpctl/tensor/_elementwise_common.py

Added wait to avoid dangling host_task

6bc4ba8

ndgrigorian reviewed May 19, 2023

View reviewed changes

Comment thread dpctl/tensor/libtensor/include/kernels/elementwise_functions/common.hpp Outdated

oleksandr-pavlyk and others added 2 commits May 18, 2023 20:37

Fixed type of output multi_ptr per PR review remark by @ndgrigorian

aebaf3a

out keyword for elementwise functions

aef6de3

update the tests

21e1415

ndgrigorian reviewed May 19, 2023

View reviewed changes

Comment thread dpctl/tensor/libtensor/source/elementwise_functions.cpp Outdated

oleksandr-pavlyk and others added 2 commits May 19, 2023 16:40

Removed unsed code

0820add

Also consolidated various *impl_fn_ptr_t which were common among unary functions, and among binary functions into common reused types.

add new tests to improve coverage

121f819

oleksandr-pavlyk and others added 4 commits May 20, 2023 11:11

Fixed tests to run on Iris Xe

05ae945

Also ensure that test_add_order exercises non-same dtypes to improve coverage.

Added a test for broadcasting error

d691846

use keywrod argument

f3d5519

Merge pull request #1209 from IntelPython/feature/elementwise-functio…

cc75cd2

…ns-out-keyword Feature/elementwise functions out keyword

Added missing license headers, updated license year to 2023

62f2d46

oleksandr-pavlyk force-pushed the feature/elementwise-functions branch from 3cf142e to 62f2d46 Compare May 22, 2023 17:06

ndgrigorian self-requested a review May 22, 2023 19:02

ndgrigorian approved these changes May 22, 2023

View reviewed changes

oleksandr-pavlyk merged commit 18d1728 into master May 22, 2023

oleksandr-pavlyk deleted the feature/elementwise-functions branch May 22, 2023 19:08

Conversation

oleksandr-pavlyk commented May 8, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented May 8, 2023

Uh oh!

coveralls commented May 9, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented May 9, 2023

Uh oh!

github-actions Bot commented May 9, 2023

Uh oh!

github-actions Bot commented May 10, 2023

Uh oh!

oleksandr-pavlyk commented May 14, 2023

Uh oh!

github-actions Bot commented May 17, 2023

Uh oh!

Uh oh!

github-actions Bot commented May 18, 2023

Uh oh!

Uh oh!

github-actions Bot commented May 18, 2023

Uh oh!

github-actions Bot commented May 18, 2023

Uh oh!

Uh oh!

github-actions Bot commented May 19, 2023

Uh oh!

Uh oh!

github-actions Bot commented May 20, 2023

Uh oh!

github-actions Bot commented May 21, 2023

Uh oh!

github-actions Bot commented May 22, 2023

Uh oh!

ndgrigorian left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented May 22, 2023

Uh oh!

github-actions Bot commented May 22, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

oleksandr-pavlyk commented May 8, 2023 •

edited

Loading

coveralls commented May 9, 2023 •

edited

Loading