Used functools.cache to cache filter_string property#1127
Merged
oleksandr-pavlyk merged 2 commits intomasterfrom Mar 21, 2023
Merged
Used functools.cache to cache filter_string property#1127oleksandr-pavlyk merged 2 commits intomasterfrom
oleksandr-pavlyk merged 2 commits intomasterfrom
Conversation
Fixed docstring of filter_string property. Introduced internal dpctl._sycl_device._cached_filter_string stand-alone function that is decorated with functools.cache Used that internal function in implementation of dpctl.SyclDevice.filter_string. Caching improved timing of filter_string property: ``` In [1]: import dpctl In [2]: d = dpctl.SyclDevice() In [3]: %timeit d.filter_string 2.31 µs ± 42.7 ns per loop (mean ± std. dev. of 7 runs, 100,000 loops each) ``` Previously, the timing was around `200 ms`.
|
View rendered docs @ https://intelpython.github.io/dpctl/pulls/1127/index.html |
Collaborator
|
Array API standard conformance tests for dpctl=0.14.2=py310h76be34b_48 ran successfully. |
|
Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞 |
|
Array API standard conformance tests for dpctl=0.14.3dev0=py310h76be34b_8 ran successfully. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Partially addresses gh-1098, improving timing of
dpctl.SyclDevice.filter_stringproperty on repeated invocations.Fixed docstring of
filter_stringproperty.Introduced internal
dpctl._sycl_device._cached_filter_stringstand-alone function that is decorated withfunctools.cache.Used that internal function in implementation of
dpctl.SyclDevice.filter_string.Caching improved timing of
filter_stringproperty:Previously, the timing was around
200 ms.Tests already exist.