Fixed build break on Debian 11 with recent OS SYCL bundle#1118
Merged
oleksandr-pavlyk merged 1 commit intomasterfrom Mar 13, 2023
Merged
Fixed build break on Debian 11 with recent OS SYCL bundle#1118oleksandr-pavlyk merged 1 commit intomasterfrom
oleksandr-pavlyk merged 1 commit intomasterfrom
Conversation
…space For open-source SYCL bundle based on clang 17.0 and using GCC 10.2 toolchain compilation error about ambiguous call to inserter was encountered. This was because of name clash between the definition in this file and std::inserter. Renaming helped resolve that. Thank you @ZzEeKkAa for reportign this issue.
ZzEeKkAa
approved these changes
Mar 13, 2023
Contributor
ZzEeKkAa
left a comment
There was a problem hiding this comment.
LGTM. Thank you for fixing it. I'm not sure if the issue is directly related to GCC headers. Issue was presented on Debian bullseye (GCC 10.2) and Debian bust (GCC 8.) but was not presented on Ubuntu 20.04 (GCC 9.) and Ubuntu 22.04 (GCC 11.*).
|
View rendered docs @ https://intelpython.github.io/dpctl/pulls/1118/index.html |
|
Array API standard conformance tests for dpctl=0.14.2=py310h76be34b_30 ran successfully. |
Collaborator
|
Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞 |
|
Array API standard conformance tests for dpctl=0.14.2=py310h76be34b_39 ran successfully. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Renamed inserter to __appender, moved functions into concat_impl namespace
For open-source SYCL bundle based on clang 17.0 and using GCC 10.2 toolchain compilation error about ambiguous call to inserter was encountered. This was because of name clash between the definition in this file and
std::inserter.Renaming helped resolve that.
Thank you @ZzEeKkAa for reporting this issue.