Hotfix/incorrect mask positions#1103
Merged
oleksandr-pavlyk merged 2 commits intomasterfrom Mar 7, 2023
Merged
Conversation
The main step of the algorithm was unconditionally applying non-zero transformer to the input data, but this should not be done on the recursive call.
|
View rendered docs @ https://intelpython.github.io/dpctl/pulls/1103/index.html |
09d3d87 to
3eed4e5
Compare
antonwolfy
reviewed
Mar 7, 2023
Collaborator
|
Array API standard conformance tests for dpctl=0.14.1=py310h76be34b_3 ran successfully. |
|
Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞 |
|
Array API standard conformance tests for dpctl=0.14.1=py310h76be34b_3 ran successfully. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue found by @antonwolfy where the following test would not clear the assertion:
This was caused by
inclusive_scan_recimplementation unconditionally applying non-zero indicator transformation on the input data, even for the recursive call where it was unintended.The fix is to add the
transformerargument to the function, and set to it to no-op for the recursive call.A test is added.