Added get_strides_vector and get_shape_vector#1090

Merged

ndgrigorian merged 3 commits intomasterfrom

usm-ndarray-shape-stride-vectors

Mar 1, 2023

Collaborator

ndgrigorian commented Mar 1, 2023 •

edited by oleksandr-pavlyk

Loading

This pull request adds methods get_strides_vector and get_shape_vector to usm_ndarray.

These functions are slightly more convenient and can be used to clean up some strides logic, especially where multiple stride copies are involved.

Have you provided a meaningful PR description?
Have you added a test, reproducer or referred to an issue with a reproducer?
Have you tested your changes locally for CPU and GPU devices?
Have you made sure that new changes do not introduce compiler warnings?
If this PR is a work in progress, are you filing the PR as a draft?

github-actions Bot commented Mar 1, 2023

View rendered docs @ https://intelpython.github.io/dpctl/pulls/1090/index.html

Collaborator

coveralls commented Mar 1, 2023 •

edited

Loading

Coverage: 82.316%. Remained the same when pulling 7082912 on usm-ndarray-shape-stride-vectors into c32423c on master.

github-actions Bot commented Mar 1, 2023

Array API standard conformance tests for dpctl=0.14.1dev2=py310h76be34b_57 ran successfully.
Passed: 33
Failed: 801
Skipped: 280


          Added get_strides_vector and get_shape_vector

df6114d

ndgrigorian force-pushed the usm-ndarray-shape-stride-vectors branch from 24b8bdd to df6114d Compare

March 1, 2023 02:01

github-actions Bot commented Mar 1, 2023

Array API standard conformance tests for dpctl=0.14.1dev2=py310h76be34b_57 ran successfully.
Passed: 33
Failed: 801
Skipped: 280

ndgrigorian requested a review from oleksandr-pavlyk

March 1, 2023 02:49

oleksandr-pavlyk reviewed

View reviewed changes

dpctl/apis/include/dpctl4pybind11.hpp Outdated

oleksandr-pavlyk reviewed

View reviewed changes

dpctl/apis/include/dpctl4pybind11.hpp Outdated

oleksandr-pavlyk reviewed

View reviewed changes

dpctl/apis/include/dpctl4pybind11.hpp Outdated

Contributor

oleksandr-pavlyk commented Mar 1, 2023

Could you please also remove uses of this->method_name() through the implementation of usm_ndarray?


          Removed uses of this->method in usm_ndarray

900b1be

github-actions Bot commented Mar 1, 2023

Array API standard conformance tests for dpctl=0.14.1dev2=py310h76be34b_58 ran successfully.
Passed: 33
Failed: 801
Skipped: 280

oleksandr-pavlyk previously approved these changes

View reviewed changes

oleksandr-pavlyk reviewed

View reviewed changes

dpctl/apis/include/dpctl4pybind11.hpp Outdated

oleksandr-pavlyk reviewed

View reviewed changes

dpctl/apis/include/dpctl4pybind11.hpp Outdated


          Apply suggestions from code review

Removed const qualifier from returned vector.

oleksandr-pavlyk dismissed their stale review via

March 1, 2023 13:30

github-actions Bot commented Mar 1, 2023

Array API standard conformance tests for dpctl=0.14.1dev2=py310h76be34b_59 ran successfully.
Passed: 33
Failed: 801
Skipped: 280

oleksandr-pavlyk approved these changes

View reviewed changes

oleksandr-pavlyk approved these changes

View reviewed changes

ndgrigorian merged commit b45e174 into master

github-actions Bot commented Mar 1, 2023

Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞

github-actions Bot commented Mar 1, 2023

Array API standard conformance tests for dpctl=0.14.1dev2=py310h76be34b_59 ran successfully.
Passed: 33
Failed: 801
Skipped: 280

ndgrigorian deleted the usm-ndarray-shape-stride-vectors branch

March 2, 2023 22:19

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet