Skip to content

Mark static function usm_ndarray_types::typenum_to_lookup_id const#1077

Merged
oleksandr-pavlyk merged 1 commit intomasterfrom
typenum_to_lookid-made-const
Feb 18, 2023
Merged

Mark static function usm_ndarray_types::typenum_to_lookup_id const#1077
oleksandr-pavlyk merged 1 commit intomasterfrom
typenum_to_lookid-made-const

Conversation

@oleksandr-pavlyk
Copy link
Copy Markdown
Contributor

Mark static function usm_ndarray_types::typenum_to_lookup_id as const.

This allows to call it for const struct references.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • If this PR is a work in progress, are you filing the PR as a draft?

This allows to call it for const struct references.
@oleksandr-pavlyk oleksandr-pavlyk force-pushed the typenum_to_lookid-made-const branch from 24099c8 to fbb25cd Compare February 18, 2023 00:15
@github-actions
Copy link
Copy Markdown

@coveralls
Copy link
Copy Markdown
Collaborator

Coverage Status

Coverage: 82.304%. Remained the same when pulling fbb25cd on typenum_to_lookid-made-const into ecbe8fb on master.

@github-actions
Copy link
Copy Markdown

Array API standard conformance tests for dpctl=0.14.1dev2=py310h41425db_24 ran successfully.
Passed: 33
Failed: 801
Skipped: 280

@oleksandr-pavlyk oleksandr-pavlyk merged commit 1754be7 into master Feb 18, 2023
@oleksandr-pavlyk oleksandr-pavlyk deleted the typenum_to_lookid-made-const branch February 18, 2023 01:12
@github-actions
Copy link
Copy Markdown

Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞

@github-actions
Copy link
Copy Markdown

Array API standard conformance tests for dpctl=0.14.1dev2=py310h41425db_24 ran successfully.
Passed: 33
Failed: 801
Skipped: 280

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants