Add double type support check condition for test_print_repr#1070
Merged
oleksandr-pavlyk merged 1 commit intoIntelPython:masterfrom Feb 10, 2023
Merged
Conversation
Collaborator
oleksandr-pavlyk
approved these changes
Feb 10, 2023
Contributor
oleksandr-pavlyk
left a comment
There was a problem hiding this comment.
Thank you @vlad-perevezentsev ! Somehow I was never running this test file as it was added after I wrote my test driver and did not get to updating it until now.
Contributor
|
Generate documentation is known to fail to push to |
oleksandr-pavlyk
approved these changes
Feb 10, 2023
|
Array API standard conformance tests for dpctl=0.14.1dev2=py310h76be34b_4 ran successfully. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR solves the issue #1069.
The PR adds the
has_aspect_fp64condition in thetest_usm_ndarray_print.py::TestPrintFns::test_print_repto check for double type support on devices and allows that this test passes on Iris Xe.