Added missing usm_type to tril() and triu() functions.#1062
Merged
oleksandr-pavlyk merged 2 commits intomasterfrom Feb 6, 2023
Merged
Added missing usm_type to tril() and triu() functions.#1062oleksandr-pavlyk merged 2 commits intomasterfrom
oleksandr-pavlyk merged 2 commits intomasterfrom
Conversation
Collaborator
Collaborator
|
Array API standard conformance tests for dpctl=0.14.1dev1=py310h76be34b_79 ran successfully. |
|
Array API standard conformance tests for dpctl=0.14.1dev1=py310h76be34b_80 ran successfully. |
|
View rendered docs @ https://intelpython.github.io/dpctl/pulls/1062/index.html |
oleksandr-pavlyk
approved these changes
Feb 6, 2023
Contributor
oleksandr-pavlyk
left a comment
There was a problem hiding this comment.
PR descriptions, and tests are useful.
PR description is useful for release note writing, and tests are useful for regression testing.
|
Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞 |
|
Array API standard conformance tests for dpctl=0.14.1dev1=py310h76be34b_80 ran successfully. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allocation for the result array did not honor
usm_typeof the argument fordpctl.tensor.tril,dpctl.tensor.triufunctions.This PR fixes that and adds tests.